Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: merge release to develop #7830

Merged
merged 2 commits into from
Nov 1, 2024
Merged

build: merge release to develop #7830

merged 2 commits into from
Nov 1, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Oct 30, 2024

No description provided.

@KenLSM
Copy link
Contributor Author

KenLSM commented Oct 30, 2024

BE tests are failing due to the snapshot being outdated. Will be updated in #7831

@datadog-opengovsg
Copy link

Datadog Report

Branch report: release-al2
Commit report: 7b7c483
Test service: formsg

❌ 2 Failed (0 Known Flaky), 3214 Passed, 1 Skipped, 21m 11.66s Total Time
➡️ Test Sessions change in coverage: 1 no change

❌ Failed Tests (2)

  • mail.service sendBounceNotification should send permanent bounce notification successfully - src/app/services/mail/__tests__/mail.service.spec.ts

  • mail.service sendBounceNotification should send transient bounce notification successfully - src/app/services/mail/__tests__/mail.service.spec.ts - Details

    Expand for error
     expect(received).toMatchSnapshot()
     
     Snapshot name: \`mail.service sendBounceNotification should send transient bounce notification successfully 1\`
     
     - Snapshot  - 1
     + Received  + 1
     
     @@ -4,11 +4,11 @@
             "from": "mockApp <[email protected]>",
             "headers": {
     ...
    

@KenLSM
Copy link
Contributor Author

KenLSM commented Nov 1, 2024

Bypassing branch protections. Approvers are away + this is not introducing feature changes.

@KenLSM KenLSM merged commit 014313f into develop Nov 1, 2024
25 of 29 checks passed
This was referenced Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant